Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataclass .py tutorial file #270

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add dataclass .py tutorial file #270

merged 2 commits into from
Nov 26, 2024

Conversation

fm1320
Copy link
Collaborator

@fm1320 fm1320 commented Nov 20, 2024 •
edited
Loading

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • [X ] Did you read the contributor guideline?
  • [X ] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [X ] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?

@fm1320 fm1320 marked this pull request as ready for review November 20, 2024 15:37
liyin2015
liyin2015 requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@liyin2015 liyin2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure only adalflow_dataclasses.py is merged, we need a consistent formatting style for all developers

@liyin2015
Copy link
Member

@fm1320 please address the conflicts and then merge

@liyin2015 liyin2015 added the ready-to-go Used for marking PR as ready to merge (used only in the PR) label Nov 25, 2024
@fm1320 fm1320 merged commit 6605301 into main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyin2015 liyin2015 liyin2015 approved these changes

Assignees
No one assigned
Labels
ready-to-go Used for marking PR as ready to merge (used only in the PR)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm1320 @liyin2015